master -> main #23132
Merged
master -> main #23132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
requested review from
adegeo,
BillWagner,
bricelam,
CamSoper,
cartermp,
gewarren,
IEvangelist,
JamesNK,
KathleenDollard,
luisquintanilla,
nishanil,
sdmaclea,
shirhatti,
sywhang,
tdykstra and
a team
as code owners
Youssef1313
commented
Mar 20, 2021
Youssef1313
commented
Mar 20, 2021
| @@ -277,7 +277,7 @@ by 3. Here are a few hints: | |||
| - The `for` loop can help you repeat a series of steps for all the numbers 1 through 20. | |||
|
|
|||
| Try it yourself. Then check how you did. You should get 63 for an answer. You can see one possible answer by | |||
| [viewing the completed code on GitHub](https://github.com/dotnet/samples/tree/master/csharp/branches-quickstart/Program.cs#L46-L54). | |||
| [viewing the completed code on GitHub](https://github.com/dotnet/samples/tree/main/csharp/branches-quickstart/Program.cs#L46-L54). | |||
There was a problem hiding this comment.
The number reference here appears to be outdated. Will file an issue and fix separately to keep this PR focused as it's already large.
Youssef1313
commented
Mar 20, 2021
Youssef1313
commented
Mar 20, 2021
Youssef1313
commented
Mar 20, 2021
Youssef1313
commented
Mar 20, 2021
Youssef1313
commented
Mar 20, 2021
Youssef1313
commented
Mar 20, 2021
| @@ -86,7 +86,7 @@ See [CLR](#clr) | |||
|
|
|||
| In contrast to the [CLR](#clr), CoreRT is not a virtual machine, which means it doesn't include the facilities to generate and run code on-the-fly because it doesn't include a [JIT](#jit). It does, however, include the [GC](#gc) and the ability for run-time type identification (RTTI) and reflection. However, its type system is designed so that metadata for reflection isn't required. Not requiring metadata enables having an [AOT](#aot) tool chain that can link away superfluous metadata and (more importantly) identify code that the app doesn't use. CoreRT is in development. | |||
|
|
|||
| See [Intro to .NET Native and CoreRT](https://github.com/dotnet/corert/blob/master/Documentation/intro-to-corert.md). | |||
| See [Intro to .NET Native and CoreRT](https://github.com/dotnet/corert/blob/main/Documentation/intro-to-corert.md). | |||
There was a problem hiding this comment.
@stephentoub Can you point to the file in dotnet/runtime that should replace this link?
|
First 2 commits are a simple regex find & replace, the later commits are all manual. |
gewarren
reviewed
Mar 22, 2021
gewarren
approved these changes
Mar 22, 2021
|
Thank you for updating all of these links Youssef! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regex:
Find:
com\/dotnet\/(.+)\/masterReplace with:
com\/dotnet\/$1\/main