Fix typo in test-aspnet-core-services-web-apps.md #20621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sughosneo
reviewed
Sep 15, 2020
...services/multi-container-microservice-net-applications/test-aspnet-core-services-web-apps.md
Outdated
Show resolved
Hide resolved
|
Hey @zakaria-c , while reviewing this PR with @nishanil when we read the sentence again we realized that there is scope of further improvement. So we rephrased it likes this - "While unit and integration tests are organized in a test folder within the microservice project, application and load tests are managed separately under the root folder, as shown in Figure 6-25". Thoughts ? Thank you. |
Contributor
Author
|
Clearer and simpler! I'll update it right away. |
nishanil
approved these changes
Sep 21, 2020
Member
nishanil
left a comment
nishanil
left a comment
There was a problem hiding this comment.
Looks great! Thanks @zakaria-c
Contributor
Author
|
You're very welcome |
BillWagner
added
dotnet-architecture/svc
microservices/subsvc
and removed
📚 Area - .NET Architecture Guide
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change the indefinite article "a" to the conjunction "and."
Add a comma before the conjunction.
Fixes #Issue_Number (if available)