Document CS8892 warning #20164
Merged
Document CS8892 warning #20164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
commented
Aug 18, 2020
Youssef1313
commented
Aug 18, 2020
Youssef1313
commented
Aug 18, 2020
Member
Author
|
@BillWagner, Roslyn's PR got merged. This is ready for review. |
BillWagner
reviewed
Aug 27, 2020
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
Commenting so this stays in my queue.
I did review all the changes @Youssef1313 and this is ready to merge once we resolve the TOC question. I'm OK merging this, and starting a new PR for updating that section of the TOC per the style guide, or adding that change to this PR. Let me know which you prefer.
BillWagner
approved these changes
Aug 28, 2020
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
This LGTM @Youssef1313
Thanks again. I'll 
now.
BillWagner
added
dotnet-csharp/svc
errors-warnings/subsvc
lang-reference/subsvc
and removed
📚 Area - C# Guide
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge before dotnet/roslyn#46832 gets merged first.(It's merged now 🎉 )