Add ASP.NET Core 3.0 breaking changes #15044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know this is a draft but wanted to call your attention to the fact that each breaking change should be in an include file so we can easily create future versions like 2.2-3.1. Maybe you already know but I thought it wouldn't hurt to say. |
|
@mairaw I plan to do that, but thank you for checking. For editing, it's much easier to have everything in a single file. |
rpetrusha
previously requested changes
Oct 9, 2019
There was a problem hiding this comment.
I've left a few comments about some things to consider changing, @scottaddie, and some additional changes to make. Since this is a work in progress, I'll review it in greater depth incrementally.
includes/core-changes/aspnetcore/3.0/action-async-suffix-trimmed.md
Outdated
Show resolved
Hide resolved
includes/core-changes/aspnetcore/3.0/action-async-suffix-trimmed.md
Outdated
Show resolved
Hide resolved
includes/core-changes/aspnetcore/3.0/add-authz-assembly-change.md
Outdated
Show resolved
Hide resolved
includes/core-changes/aspnetcore/3.0/add-authz-assembly-change.md
Outdated
Show resolved
Hide resolved
includes/core-changes/aspnetcore/3.0/action-async-suffix-trimmed.md
Outdated
Show resolved
Hide resolved
includes/core-changes/aspnetcore/3.0/all-shared-framework-removed.md
Outdated
Show resolved
Hide resolved
includes/core-changes/aspnetcore/3.0/ancmv1-hosting-bundle-removal.md
Outdated
Show resolved
Hide resolved
includes/core-changes/aspnetcore/3.0/ancmv1-hosting-bundle-removal.md
Outdated
Show resolved
Hide resolved
jchannon
reviewed
Oct 13, 2019
includes/core-changes/aspnetcore/3.0/add-authz-assembly-change.md
Outdated
Show resolved
Hide resolved
mairaw
reviewed
Oct 14, 2019
includes/core-changes/aspnetcore/3.0/http-defaulthttpcontext-extensibility-removed.md
Outdated
Show resolved
Hide resolved
includes/core-changes/aspnetcore/3.0/identity-ui-bootstrap-version.md
Outdated
Show resolved
Hide resolved
includes/core-changes/aspnetcore/3.0/kestrel-request-trailer-headers.md
Outdated
Show resolved
Hide resolved
includes/core-changes/aspnetcore/3.0/mvc-pubternal-to-internal.md
Outdated
Show resolved
Hide resolved
includes/core-changes/aspnetcore/3.0/caching-response-pubternal-to-internal.md
Outdated
Show resolved
Hide resolved
includes/core-changes/aspnetcore/3.0/dataprotection-azstorage-using-azstorage-apis.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: Maira Wenzel <[email protected]>
|
@mairaw It's ready for another look. |
mairaw
requested changes
Oct 16, 2019
includes/core-changes/aspnetcore/3.0/http-headernames-constants-staticreadonly.md
Outdated
Show resolved
Hide resolved
includes/core-changes/aspnetcore/3.0/http-headernames-constants-staticreadonly.md
Outdated
Show resolved
Hide resolved
includes/core-changes/aspnetcore/3.0/caching-memory-property-removed.md
Outdated
Show resolved
Hide resolved
includes/core-changes/aspnetcore/3.0/authn-google-plus-authn-changes.md
Outdated
Show resolved
Hide resolved
includes/core-changes/aspnetcore/3.0/caching-new-sqlclient-package.md
Outdated
Show resolved
Hide resolved
includes/core-changes/aspnetcore/3.0/targetfx-netfx-tfm-support.md
Outdated
Show resolved
Hide resolved
includes/core-changes/aspnetcore/3.0/authn-exchangecodeasync-signature-change.md
Outdated
Show resolved
Hide resolved
includes/core-changes/aspnetcore/3.0/identity-signinmanager-ctor-parameter.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: Maira Wenzel <[email protected]>
|
@mairaw Ready for another look. |
mairaw
approved these changes
Oct 16, 2019
scottaddie
dismissed
rpetrusha’s stale review
Ron has retired! Happy retirement, Ron!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14884
Fixes #14525
Fixes #14959
Fixes #14958
Fixes #14708
Fixes #14832
Fixes #14834
Fixes #14828
Fixes #14906
Fixes #14905
Fixes #14847
Fixes #14845
Fixes #14943
Fixes #14941
Fixes #14942
Fixes #14881
Fixes #14928
Fixes #14929
Fixes #14960
Fixes #14882
Fixes #14901
Fixes #14897
Fixes #14898
Fixes #14900
Fixes #14716
Fixes #14762
Fixes #14753
Fixes #14926
Fixes #14925
Fixes #14835
Fixes #14836
Fixes #14772
Fixes #14770
Fixes #14771
Fixes #14732
Fixes #14736
Fixes #14843
Fixes #14844
Fixes #14903
Fixes #14902
Fixes #14950
Fixes #14948
Fixes #14717
Fixes #14963
Fixes #14961
Fixes #14962