Skip to content

chore: fix CI error of plantuml tests #10528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Feb 1, 2025

This PR intended to fix folowing nightly CI build issue.

Reported error content

Expected: hello</text><!--SRC=[SyfFKj2rKt3CoKnELR1Io4ZDoSa70000]--></g></svg></div>
Actual:   hello</text></g><!--SRC=[SyfFKj2rKt3CoKnELR1Io4ZDoSa70000]--></g></svg></div>

PlantUML Online Server related tests are frequently broken by server update.
And remaining test don't validate SVG content. it validate header/footer only. (#9858)
So I've changed test code to skip by default.

@filzrev
Copy link
Contributor Author

filzrev commented Feb 4, 2025

@yufeih
Is it able to review & merge this PR with higher priority?
Because PR that created by depentabot are failed.

@yufeih yufeih merged commit f99ba39 into dotnet:main Feb 18, 2025
10 checks passed
filzrev added a commit to filzrev/docfx that referenced this pull request Feb 18, 2025
chore: fix ci error of plantuml test
filzrev added a commit to filzrev/docfx that referenced this pull request Feb 18, 2025
chore: fix ci error of plantuml test
filzrev added a commit to filzrev/docfx that referenced this pull request Mar 1, 2025
chore: fix ci error of plantuml test
filzrev added a commit to filzrev/docfx that referenced this pull request May 27, 2025
chore: fix ci error of plantuml test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants