-
Couldn't load subscription status.
- Fork 381
[dsrouter] fix web socket startup #5121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @lateralusX |
src/Microsoft.Diagnostics.NETCore.Client/ReversedServer/ReversedDiagnosticsServer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Diagnostics.NETCore.Client/ReversedServer/ReversedDiagnosticsServer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Diagnostics.NETCore.Client/ReversedServer/ReversedDiagnosticsServer.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
src/Microsoft.Diagnostics.WebSocketServer/WebSocketServerImpl.cs
Outdated
Show resolved
Hide resolved
It probably worked if you passed |
|
And for clarification, its not a conflicting user experience to pass in Is there a blocker to make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me if the ws/wss -> http/https would be expected/okay from a user standpoint and if the end-to-end scenario can be tested (I'm assuming there's no automated tests for ws/wss since it turned out it doesn't work)
WS of built on top of HTTP, it's protocol upgrade scheme. You need HTTP server to be able to handle WS endpoints.
I'm end to end testing manually with dotnet/runtime#110818 @mdh1418 could you please click merge on my behalf ? I don't have the permissions on this repo. Also when it's the next release of these tools ? |
|
@mikem8361 @hoyosjs any estimates for when the next release might be? |
|
This just missed the next train. And it's likely to be a bit before an official release |
ws://127.0.0.1:8088/diagnosticsws://orwss://as it only acceptshttp://orhttps://schemaContributes to dotnet/runtime#76316