Skip to content

Conversation

@terrajobst
Copy link
Contributor

@terrajobst terrajobst commented Nov 13, 2020

Based on feedback

@sebastienros
Copy link
Member

Can we just count the legal votes?

@dotMorten
Copy link

dotMorten commented Nov 13, 2020

OR_GREATER makes more sense IMHO. It's a version check, not a date check. 5.1 could potentially be released after 6.0.

It also makes sense as part of the discussion we had about potentially having range check support in the future. Ie #if NETVERSION>=5.0.

@davkean
Copy link
Member

davkean commented Nov 13, 2020

Windows does OR_GREATER: https://docs.microsoft.com/en-us/windows/win32/sysinfo/getting-the-system-version.

@ericsampson
Copy link

Will a N-1 minor release ever happen after a N major? If so, @dotMorten has a point...

@dotMorten
Copy link

dotMorten commented Nov 14, 2020

@ericsampson My understanding is it isn't the plan, but also never say never...

Can't we all also agree that the latest .NET version is just sooooo much greater than the previous one? :-D

@JamesNK
Copy link
Member

JamesNK commented Nov 14, 2020

Docs tend to use "or later" when talking about version numbers:

https://www.google.com/search?q=site%3Adocs.microsoft.com+%22or+later%22

@Tyrrrz
Copy link

Tyrrrz commented Nov 14, 2020

How long until full pattern matching support in compilation directives?

@Nirmal4G
Copy link

@dotMorten If you guys are sure about range check then do that instead of this.

I think having two similar things might make it worse than intented.

I vote for range check. It's simple.

@dotMorten
Copy link

@Nirmal4G range check is a potential future long-term feature. Nothing for sure.

@mehrandvd
Copy link

OR_GREATER makes more sense IMHO. It's a version check, not a date check. 5.1 could potentially be released after 6.0.

It also makes sense as part of the discussion we had about potentially having range check support in the future. Ie #if NETVERSION>=5.0.

What about OR_NEWER?

Copy link

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greater makes more sense IMHO, there might be things released later that aren't greater.

@umbarov
Copy link

umbarov commented Nov 14, 2020

GREATER goes well with numbers. LATER goes well with code names.

NET5_0_OR_GREATER
NET_PUMPKIN_OR_LATER

@PathogenDavid
Copy link
Contributor

If we’re going to have a bikeshed party, I’d like to complicate things by proposing _OR_NEWER, which is what Unity uses.

(I’m half joking, but I do think there’s some merit to remaining consistent with a segment of the .NET ecosystem that has actively encouraged/enabled platform-specific code through preprocessor for quite some time.)

@theo-albers
Copy link

theo-albers commented Nov 14, 2020

I suggest OR_HIGHER. This works for none versions as well, like "bachelor's degree or higher".

@jaredpar
Copy link
Member

Do we need to take this now OR_LATER?

@dotMorten
Copy link

@jaredpar I think it needs to be AND_NEVER

@terrajobst
Copy link
Contributor Author

OK, considering the voting distribution I think we leave this as OR_GREATER.

@terrajobst terrajobst closed this Nov 16, 2020
@terrajobst terrajobst deleted the rename-or-greater-to-or-later branch November 16, 2020 19:31
radekdoulik added a commit to radekdoulik/java.interop that referenced this pull request Nov 23, 2020
...until the situation around NET defines clears out.

Contex: dotnet/designs#165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.