-
Notifications
You must be signed in to change notification settings - Fork 167
Rename OR_GREATER to OR_LATER #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can we just count the legal votes? |
|
OR_GREATER makes more sense IMHO. It's a version check, not a date check. 5.1 could potentially be released after 6.0. It also makes sense as part of the discussion we had about potentially having range check support in the future. Ie |
|
Windows does OR_GREATER: https://docs.microsoft.com/en-us/windows/win32/sysinfo/getting-the-system-version. |
|
Will a N-1 minor release ever happen after a N major? If so, @dotMorten has a point... |
|
@ericsampson My understanding is it isn't the plan, but also never say never... Can't we all also agree that the latest .NET version is just sooooo much greater than the previous one? :-D |
|
Docs tend to use "or later" when talking about version numbers: https://www.google.com/search?q=site%3Adocs.microsoft.com+%22or+later%22 |
|
How long until full pattern matching support in compilation directives? |
|
@dotMorten If you guys are sure about range check then do that instead of this. I think having two similar things might make it worse than intented. I vote for range check. It's simple. |
|
@Nirmal4G range check is a potential future long-term feature. Nothing for sure. |
What about OR_NEWER? |
devlead
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greater makes more sense IMHO, there might be things released later that aren't greater.
|
GREATER goes well with numbers. LATER goes well with code names. |
|
If we’re going to have a bikeshed party, I’d like to complicate things by proposing (I’m half joking, but I do think there’s some merit to remaining consistent with a segment of the .NET ecosystem that has actively encouraged/enabled platform-specific code through preprocessor for quite some time.) |
|
I suggest OR_HIGHER. This works for none versions as well, like "bachelor's degree or higher". |
|
Do we need to take this now |
|
@jaredpar I think it needs to be |
|
OK, considering the voting distribution I think we leave this as |
...until the situation around NET defines clears out. Contex: dotnet/designs#165
Based on feedback