Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

@JeremyKuhne
Copy link
Member

Copy ArrayPool source from CoreFX and expose in System.Private.CoreLib.

This is part of facilitating the move of FileStream.
https://github.com/dotnet/corefx/issues/12810

@ianhays, @stephentoub, @sokket, @jkotas

Copy ArrayPool source from CoreFX and expose in System.Private.CoreLib.
@JeremyKuhne
Copy link
Member Author

@dotnet-bot Test this please (Jenkins rebooted)

Copy link

@ianhays ianhays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were any changes to the CoreFX sources required or did you just have to copy-paste those?

The build stuff LGTM.

@ericstj
Copy link
Member

ericstj commented Oct 20, 2016

It looks ok to me. In corefx we'll want to cross-compile buffers for netcoreapp1.1 as a partial facade.

@JeremyKuhne
Copy link
Member Author

@ianhays This was just a straight copy, except for the string resource.

@JeremyKuhne JeremyKuhne merged commit 74cbc9e into dotnet:master Oct 20, 2016
@JeremyKuhne JeremyKuhne deleted the ArrayPool branch October 20, 2016 18:48
@jamesqo
Copy link

jamesqo commented Oct 20, 2016

Awesome! We should definitely look into using this for the default Stream.CopyTo / CopyToAsync impl.

@jkotas
Copy link
Member

jkotas commented Oct 21, 2016

@Maoni0 The ArrayPool is part of CoreLib now .... it may be interesting to look into whether it would be worth it to make GC aware of it, to get better perf characteristics.

@Maoni0
Copy link
Member

Maoni0 commented Oct 21, 2016

thanks Jan. @vancem did a pinnable buffer pool implementation. I can see some of the heuristics being used in this buffer pool as impl well. it goes the other way - it's aware of GCs happening; we can look at it from that direction first.

@swgillespie @adityamandaleeka

jkotas added a commit to dotnet/corert that referenced this pull request Dec 26, 2016
Add ArrayPool to CoreLib. Port of dotnet/coreclr#7734 to CoreRT. Path and File I/O depends on it.
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants