Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Replace isVararg with GetIsVararg() #26891

Merged
merged 2 commits into from
Sep 26, 2019
Merged

Replace isVararg with GetIsVararg() #26891

merged 2 commits into from
Sep 26, 2019

Conversation

franksinankaya
Copy link

sandreenko
sandreenko approved these changes Sep 25, 2019
View reviewed changes
Copy link

@sandreenko sandreenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
cc @dotnet/jit-contrib

@sandreenko sandreenko merged commit c51f50b into dotnet:master Sep 26, 2019
@franksinankaya franksinankaya deleted the frkaya/isVararg branch September 26, 2019 00:48
@briansull
Copy link

Why not just IsVararg() ?
For an "Is" function it is awkward to prepend a "Get"

@franksinankaya
Copy link
Author

Sure, I'll post a PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@jashook jashook jashook approved these changes

@sandreenko sandreenko sandreenko approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area-CodeGen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@franksinankaya @briansull @jashook @sandreenko