This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Protect SuperPMI from crashes calling jitStartup #17531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we call jitStartup, we pass a JitHost interface that the JIT calls to query for data. These queries look up in the recorded MCH data, and could fail (and throw an exception) if data is missing, which it can be for running non-matching altjit against a collection. Protect these calls with exception handling.
sandreenko
reviewed
Apr 12, 2018
sandreenko
left a comment
sandreenko
left a comment
There was a problem hiding this comment.
LGTM, could you add an example how to repro it? I did not hit it when ran arm altjit jobs.
Author
|
I hit it with desktop arm64 altjit asm diffs. |
sandreenko
approved these changes
Apr 12, 2018
Author
|
@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test |
Author
|
@dotnet/dnceng The OSX job failed some tests with: |
Member
|
Thanks @BruceForstall . Created issue https://github.com/dotnet/core-eng/issues/3284 to disable the machine and do cleanup on it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we call jitStartup, we pass a JitHost interface that the JIT
calls to query for data. These queries look up in the recorded
MCH data, and could fail (and throw an exception) if data is
missing, which it can be for running non-matching altjit against
a collection. Protect these calls with exception handling.