Skip to content

Conversation

guardrex
Copy link
Contributor

@guardrex guardrex commented Aug 21, 2025

Fixes #558

We don't use the terminology "Blazor WASM" in the Blazor docs for Blazor WebAssembly apps. It's only used in link text that we don't control. Therefore, I've used "Blazor WebAssembly" here (BlazorWebAssemblyReact, DotNetWebAssemblyReact).

BTW: Changed "BlazorComponent" 👉 "RazorComponent" (official name)

As soon as we merge this, I'll update the cross-links in the article section to point to these samps.

Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may happen that I provided some of the (especially deletions) in only one of the samples, but they may apply to both. Please look at them in both.

I'm not sure using "WebAssembly" for Blazor sample and "Wasm" for .NET based is good idea. I would prefer using the same term in both, as we probably do in the docs.

@guardrex
Copy link
Contributor Author

guardrex commented Aug 25, 2025

Thanks @maraf ... I'll get these updates in within an hour or so ... just wrapping up something else at the moment 🏃‍♂️.

UPDATE: Latest suggestions applied! 🎉

@guardrex
Copy link
Contributor Author

guardrex commented Aug 25, 2025

@maraf ...❓... Should the .NET sample be named "DotNetWebAssemblyReact" (instead of "DotNetWasmReact"), which matches what I did with the other project name? It seems so to me. I saw your response ☝️ ... and ..........

UPDATE: Rubber 🦆 says, "Yeah!" (even before I saw your response) ... I just changed it.

Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor nits...

A general question, are you building & running the samples as part of changing / upgrading them?

},
plugins: [
legacy({
"../blazor/bin/Release/net10.0/publish/wwwroot/_framework/blazor.webassembly.js": "window.Blazor"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for future update: The path will change in .NET 11

Copy link
Contributor Author

@guardrex guardrex Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ... I created a tracking item for it.

@guardrex
Copy link
Contributor Author

A general question, are you building & running the samples as part of changing / upgrading them?

Yes ... I will try to build and run them. However, I might not be set up here for Node at this time. I have a new-ish (two-year old) PC that I don't think has Node on it.

@guardrex
Copy link
Contributor Author

guardrex commented Aug 26, 2025

@maraf ... Do you have anything else on this one? I'll go ahead without @danroth27's feedback. I haven't heard from him in quite a while, so he must be buried in work/trips/talks.

After this goes in, I'll update the article by merging #35974. BTW if you have write access to our repos, you could trying to approve that one 👈 for me so that I can get it merged. The new policy is that every PR ... no matter how trivial ... has to have a sign-off, even for a misspelled word or a broken link 😩.

@guardrex guardrex merged commit c854927 into main Aug 26, 2025
2 checks passed
@guardrex guardrex deleted the guardrex/move-samples branch August 26, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move blazor-wasm-react and dotnet-wasm-react samples into this repo
2 participants