-
Notifications
You must be signed in to change notification settings - Fork 803
Add React samples #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add React samples #574
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may happen that I provided some of the (especially deletions) in only one of the samples, but they may apply to both. Please look at them in both.
I'm not sure using "WebAssembly" for Blazor sample and "Wasm" for .NET based is good idea. I would prefer using the same term in both, as we probably do in the docs.
Thanks @maraf ... I'll get these updates in within an hour or so ... just wrapping up something else at the moment 🏃♂️. UPDATE: Latest suggestions applied! 🎉 |
@maraf ...❓... UPDATE: Rubber 🦆 says, "Yeah!" (even before I saw your response) ... I just changed it. |
Co-authored-by: Marek Fišera <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor nits...
A general question, are you building & running the samples as part of changing / upgrading them?
}, | ||
plugins: [ | ||
legacy({ | ||
"../blazor/bin/Release/net10.0/publish/wwwroot/_framework/blazor.webassembly.js": "window.Blazor" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for future update: The path will change in .NET 11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ... I created a tracking item for it.
Yes ... I will try to build and run them. However, I might not be set up here for Node at this time. I have a new-ish (two-year old) PC that I don't think has Node on it. |
@maraf ... Do you have anything else on this one? I'll go ahead without @danroth27's feedback. I haven't heard from him in quite a while, so he must be buried in work/trips/talks. After this goes in, I'll update the article by merging #35974. BTW if you have write access to our repos, you could trying to approve that one 👈 for me so that I can get it merged. The new policy is that every PR ... no matter how trivial ... has to have a sign-off, even for a misspelled word or a broken link 😩. |
Fixes #558
We don't use the terminology "Blazor WASM" in the Blazor docs for Blazor WebAssembly apps. It's only used in link text that we don't control. Therefore, I've used "Blazor WebAssembly" here (
BlazorWebAssemblyReact
,DotNetWebAssemblyReact
).BTW: Changed "BlazorComponent" 👉 "RazorComponent" (official name)
As soon as we merge this, I'll update the cross-links in the article section to point to these samps.