-
Notifications
You must be signed in to change notification settings - Fork 10.4k
RequiredPolicy reborn and less demanding as FallbackPolicy #9759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
c9783a6
Revert changes
HaoK 74c1690
Revert "Remove RequiredPolicy (#9399)"
HaoK 53b862b
Switch required to fallback logic instead
HaoK 0153887
Update Microsoft.AspNetCore.Authorization.Policy.netcoreapp3.0.cs
HaoK 12497cf
Update Microsoft.AspNetCore.Authorization.Policy.netcoreapp3.0.cs
HaoK 1e51db3
Update MinimumAgePolicyProvider.cs
HaoK 4c07d23
default Fallback implementation is to call DefaultPolicy
HaoK 2b5a207
Update refs
HaoK eb28114
Update MinimumAgePolicyProvider.cs
HaoK 39d6fa8
Update IAuthorizationPolicyProvider.cs
HaoK 0f9960a
Update AuthorizationPolicy.cs
HaoK 10da604
Update FallbackPolicy comments
HaoK 4505687
Update comments
HaoK b0f1ac3
Update IAuthorizationPolicyProvider.cs
HaoK 8c1f3e7
Update MinimumAgePolicyProvider.cs
HaoK a85762c
Update AuthorizeFilterIntegrationTest.cs
HaoK af37233
Update AuthorizeFilterTest.cs
HaoK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,7 @@ public class DefaultAuthorizationPolicyProvider : IAuthorizationPolicyProvider | |
{ | ||
private readonly AuthorizationOptions _options; | ||
private Task<AuthorizationPolicy> _cachedDefaultPolicy; | ||
private Task<AuthorizationPolicy> _cachedFallbackPolicy; | ||
|
||
/// <summary> | ||
/// Creates a new instance of <see cref="DefaultAuthorizationPolicyProvider"/>. | ||
|
@@ -39,6 +40,15 @@ public Task<AuthorizationPolicy> GetDefaultPolicyAsync() | |
return GetCachedPolicy(ref _cachedDefaultPolicy, _options.DefaultPolicy); | ||
} | ||
|
||
/// <summary> | ||
/// Gets the fallback authorization policy. | ||
/// </summary> | ||
/// <returns>The fallback authorization policy.</returns> | ||
public Task<AuthorizationPolicy> GetFallbackPolicyAsync() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I kinda want to make new methods ValueTask |
||
{ | ||
return GetCachedPolicy(ref _cachedFallbackPolicy, _options.FallbackPolicy); | ||
} | ||
|
||
private Task<AuthorizationPolicy> GetCachedPolicy(ref Task<AuthorizationPolicy> cachedPolicy, AuthorizationPolicy currentPolicy) | ||
{ | ||
var local = cachedPolicy; | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.