Skip to content

Update DataProtection.AzureStorage to use latest Azure SDK dependency (Microsoft.Azure.Storage.Blob) #9465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2019
Merged

Update DataProtection.AzureStorage to use latest Azure SDK dependency (Microsoft.Azure.Storage.Blob) #9465

merged 1 commit into from
Apr 18, 2019

Conversation

natemcmaster
Copy link
Contributor

Fix #8472. The Azure Storage SDK has gone through some major updates since our last update. Notably, the entire API has been moved into a namespace and the packages have new IDs. This updates the DataProtection.AzureStorage extension to use the new APIs. It is a breaking change because of the new namespaces and APIs.

@natemcmaster natemcmaster added the breaking-change This issue / pr will introduce a breaking change, when resolved / merged. label Apr 17, 2019
@natemcmaster natemcmaster requested review from Eilon and blowdart April 17, 2019 16:46
@natemcmaster natemcmaster requested a review from a team as a code owner April 17, 2019 16:46
@natemcmaster natemcmaster added this to the 3.0.0-preview5 milestone Apr 17, 2019
@natemcmaster natemcmaster added the area-dataprotection Includes: DataProtection label Apr 17, 2019
blowdart
blowdart approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@blowdart blowdart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well as long as it works :)

@natemcmaster
Copy link
Contributor Author

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=159075

@aspnet-hello
Copy link

This comment was made automatically. If there is a problem contact ryanbrandenburg.

I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/2306

dougbu
dougbu approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eng/ and .csproj changes look correct and changed files are compiling 😺

Eilon
Eilon approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@Eilon Eilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a'ight. Please remember to post an announcement after merging.

src/DataProtection/AzureStorage/src/Microsoft.AspNetCore.DataProtection.AzureStorage.csproj
</ItemGroup>

<ItemGroup Condition="'$(AspNetCoreMajorMinorVersion)' == '3.0'">
<!-- This dependency was replaced by Microsoft.Azure.Storage.Blob between 3.0 and 2.2. This suppression can be removed after 3.0 is complete. -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to file a bug to remember this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #9473 and put it in the 3.1 milestone. It's not super urgent because I've written this code to only apply when building 3.0. But yes, can be deleted later when it effectively becomes dead code.

@natemcmaster
Copy link
Contributor Author 

LINK : fatal error C1047: The object or library file 'F:\workspace\_work\1\s\src\Installers\Windows\AspNetCoreModule-Setup\IIS-Setup\iisca\lib\x64\Release\iisca.lib' was created with an older compiler than other objects; rebuild old objects and libraries [F:\workspace\_work\1\s\src\Installers\Windows\AspNetCoreModule-Setup\CustomAction\aspnetcoreCA.vcxproj]
LINK : fatal error LNK1257: code generation failed [F:\workspace\_work\1\s\src\Installers\Windows\AspNetCoreModule-Setup\CustomAction\aspnetcoreCA.vcxproj]
LINK : fatal error C1047: The object or library file 'F:\workspace\_work\1\s\src\Installers\Windows\AspNetCoreModule-Setup\IIS-Setup\iisca\lib\Release\iisca.lib' was created with an older compiler than other objects; rebuild old objects and libraries [F:\workspace\_work\1\s\src\Installers\Windows\AspNetCoreModule-Setup\CustomAction\aspnetcoreCA.vcxproj]
LINK : fatal error LNK1257: code generation failed [F:\workspace\_work\1\s\src\Installers\Windows\AspNetCoreModule-Setup\CustomAction\aspnetcoreCA.vcxproj]

@jkotalik is this a known issue with VS2019 and ANCM installer code? My changes are unrelated to this and there have been two build failures on this PR due to this.

cc @aspnet/build
@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=159075&view=logs

@jkotalik
Copy link
Contributor

I think 01b0c88 could have broken this. I'll take a look now.

@jkotalik
Copy link
Contributor

@natemcmaster is going to revert the commit while I look into what is broken.

@natemcmaster natemcmaster merged commit e4328b2 into dotnet:master Apr 18, 2019
@natemcmaster natemcmaster deleted the azure-storage branch April 18, 2019 00:25
@natemcmaster natemcmaster mentioned this pull request Apr 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eilon Eilon Eilon approved these changes

@blowdart blowdart blowdart approved these changes

@dougbu dougbu dougbu approved these changes

Assignees
No one assigned
Labels
area-dataprotection Includes: DataProtection breaking-change This issue / pr will introduce a breaking change, when resolved / merged.
Projects
None yet
Milestone
3.0.0-preview5
Development

Successfully merging this pull request may close these issues.

Asp.net core using storage nuget package from 2017 results in nuget conflict
6 participants
@natemcmaster @aspnet-hello @jkotalik @Eilon @blowdart @dougbu