Skip to content

Asp.net core using storage nuget package from 2017 results in nuget conflict #8472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hansmbakker opened this issue Mar 13, 2019 · 3 comments · Fixed by #9465
Closed

Asp.net core using storage nuget package from 2017 results in nuget conflict #8472

hansmbakker opened this issue Mar 13, 2019 · 3 comments · Fixed by #9465
Assignees
Labels
area-dataprotection Includes: DataProtection breaking-change This issue / pr will introduce a breaking change, when resolved / merged. Done This issue has been fixed

Comments

@hansmbakker
Copy link
Contributor

hansmbakker commented Mar 13, 2019

Describe the bug

Microsoft.AspNetCore.DataProtection.AzureStorage depends on WindowsAzure.Storage, a nuget package from 2017 😱. This creates conflicts e.g. when also using Nuget packages that rely on its modern replacement (Microsoft.Azure.Storage.*). E.g. Bot Framework does this.

This is an issue for my project.

Error I'm getting:

The type 'CloudStorageAccount' exists in both 'Microsoft.Azure.Storage.Common, Version=9.4.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' and 'Microsoft.WindowsAzure.Storage, Version=8.1.4.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'
@blowdart
Copy link
Contributor

@muratg Who can I borrow for data protection right now?

@muratg
Copy link
Contributor

muratg commented Mar 13, 2019

cc @Eilon

@natemcmaster
Copy link
Contributor

We are updating DataProtection.AzureStorage in 3.0 to use the new Microsoft.Azure.Storage.Blob dependency. This should resolve the compiler conflict in the scenario originally reported.

If you want to use Microsoft.Azure.Storage.Blob in 2.1 and 2.2 apps along with DataProtection.AzureStorage, you can resolve the compiler error by fully-qualifying the type reference, or adding a using such as this to the top of your file.

using CloudStorageAccount = Microsoft.Azure.Storage.CloudStorageAccount;

Closing as we do not plan to update 2.1 or 2.2 to use Microsoft.Azure.Storage APIs.

@natemcmaster natemcmaster added Done This issue has been fixed and removed 2 - Working labels Apr 18, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-dataprotection Includes: DataProtection breaking-change This issue / pr will introduce a breaking change, when resolved / merged. Done This issue has been fixed
Projects
None yet
5 participants