Fix base URI during prerendering #8910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveSandersonMS
added
area-mvc
| // Arrange | ||
| var circuitFactory = new TestCircuitFactory(); | ||
| var circuitPrerenderer = new CircuitPrerenderer(circuitFactory); | ||
| var httpContext = new Mock<HttpContext>(); |
There was a problem hiding this comment.
I strongly dislike mocking (any set of tests based around mocks tends to degrade into a write-only copy-paste fest), so I'm sad to be using it here. But other than handling this entirely as E2E tests, it's probably the only viable way to cover our interaction with HttpContext.
There was a problem hiding this comment.
I forgot to mention. You don't have to mock. You can simply do new DefaultHttpContext() and save yourself some pain. Sorry I missed that.
javiercn
approved these changes
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While creating E2E tests for the new
IComponentContext, I tried to do prerendering with an app mounted on a non-root pathbase, and found this bug.