Skip to content

Conversation

marquesm91
Copy link
Contributor

@marquesm91 marquesm91 commented Mar 16, 2019

Summary of the changes

  • Changed word Component to component in <Route path={...} Component={...} /> in App.js
  • Applied patches suggested in comment
  • Added await in const token = authService.getAccessToken(); to ensure token resolves itself

Addresses #8381 #8380 #8405 #8398

@dnfclas
Copy link

dnfclas commented Mar 16, 2019

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@mkArtak mkArtak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort, @marquesm91.
@javiercn, @ryanbrandenburg this looks good to me.
If you have no concerns with this, let's merge.

@marquesm91
Copy link
Contributor Author

marquesm91 commented Mar 17, 2019

Thank you @mkArtak! If you guys need an improvement on this template I can open a new PR. I can bump package versions (making possible to use React Hooks in 16.8) and add more real world examples.

@mkArtak
Copy link
Contributor

mkArtak commented Mar 17, 2019

Thanks @marquesm91.
Let's stick to the issues we plan to do. If you find one you're passionate about, and we have assigned it a milestone, feel free to send a PR. We'll definitely consider it.

@javiercn javiercn merged commit 5c6e1aa into dotnet:master Mar 18, 2019
@javiercn
Copy link
Member

@marquesm91 Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants