Add option to restrict the maximum hub message size #8135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This change moves the limit checking from the transport layer to the protocol parsing layer. One nice side effect is that it gives us better control over error handling.
davidfowl
commented
Mar 3, 2019
| @@ -72,7 +72,7 @@ public static IServiceProvider CreateServiceProvider(Action<ServiceCollection> a | |||
| return services.BuildServiceProvider(); | |||
| } | |||
|
|
|||
| public static Connections.ConnectionHandler GetHubConnectionHandler(Type hubType, Action<ServiceCollection> addServices = null, ILoggerFactory loggerFactory = null) | |||
| public static Connections.ConnectionHandler GetHubConnectionHandler(Type hubType, ILoggerFactory loggerFactory = null, Action<ServiceCollection> addServices = null) | |||
There was a problem hiding this comment.
Lambdas should be last.
JamesNK
reviewed
Mar 3, 2019
| } | ||
|
|
||
| [Fact] | ||
| public async Task ManyHubMessagesUnderTheMessageSizeButConfiguredWithMax() |
- Rename the property to MaximumReceiveMessageSize
JamesNK
approved these changes
Mar 3, 2019
BrennanConroy
approved these changes
Mar 3, 2019
| client.Connection.Application.Output.Write(payload3); | ||
| await client.Connection.Application.Output.FlushAsync(); | ||
|
|
||
| // 2 invocations should be processed |
| @@ -36,6 +36,11 @@ public class HubOptions | |||
| /// </summary> | |||
| public IList<string> SupportedProtocols { get; set; } = null; | |||
|
|
|||
| /// <summary> | |||
| /// Gets or sets the maximum message size of a single incoming hub message. The default is 32KB. | |||
There was a problem hiding this comment.
"Null means no maximum message size" or is that implicit with nullable types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8121 and #5307
Notes: