Skip to content

Enforce buffer limits after Pipe behavior change #8121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BrennanConroy opened this issue Mar 2, 2019 · 0 comments
Closed

Enforce buffer limits after Pipe behavior change #8121

BrennanConroy opened this issue Mar 2, 2019 · 0 comments
Assignees
Labels
accepted This issue has completed "acceptance" testing (including accessibility) area-signalr Includes: SignalR clients and servers

Comments

@BrennanConroy
Copy link
Member

We need to react to dotnet/corefx#35711 which removes the old behavior of throwing when the writer is waiting because of backpressure and the reader examines everything but doesn't consume. Instead the reader will now unblock the current write allowing more data to be buffered.

We'll need to enforce our own limits in the HubConnectionHandler.DispatchMessagesAsync() method.

@BrennanConroy BrennanConroy added the area-signalr Includes: SignalR clients and servers label Mar 2, 2019
@davidfowl davidfowl added this to the 3.0.0-preview4 milestone Mar 2, 2019
@davidfowl davidfowl self-assigned this Mar 3, 2019
@analogrelay analogrelay added the accepted This issue has completed "acceptance" testing (including accessibility) label Apr 16, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted This issue has completed "acceptance" testing (including accessibility) area-signalr Includes: SignalR clients and servers
Projects
None yet
Development

No branches or pull requests

3 participants