Skip to content

C++ client: string_t to string #8063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 3, 2019
Merged

C++ client: string_t to string #8063

merged 6 commits into from
Mar 3, 2019

Conversation

BrennanConroy
Copy link
Member

Remove most usages of utility::string_t and replace with std::string

@BrennanConroy BrennanConroy added the area-signalr Includes: SignalR clients and servers label Mar 1, 2019
@analogrelay
Copy link
Contributor

@BrennanConroy please rebase and triage failure in ConnectionCanSendAndReceiveDifferentMessageSizesWebSocketsTransport. If that failure is definitely not related to your PR, just skip it and file a bug to review (tag me in that bug)

@BrennanConroy BrennanConroy merged commit 67d339e into master Mar 3, 2019
@BrennanConroy BrennanConroy deleted the brecon/string branch March 3, 2019 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 approved these changes

@mikaelm12 mikaelm12 Awaiting requested review from mikaelm12

Assignees
No one assigned
Labels
area-signalr Includes: SignalR clients and servers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrennanConroy @analogrelay @halter73