Skip to content

Make GetMemory use MaxBufferSize for MemoryPool #7143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 4, 2019
Merged

Make GetMemory use MaxBufferSize for MemoryPool #7143

merged 2 commits into from
Feb 4, 2019

Conversation

jkotalik
Copy link
Contributor

Another issue with StreamPipeWriter found by #7110

@jkotalik jkotalik requested review from halter73 and Tratcher January 30, 2019 20:40
@jkotalik jkotalik mentioned this pull request Jan 30, 2019
Merged
halter73
halter73 reviewed Jan 30, 2019
View reviewed changes
src/Http/Http/test/PipeWriterTests.cs
var secondSpan = Writer.GetSpan(10000);

Assert.False(span.SequenceEqual(secondSpan));
Assert.Equal(4096, span.Length);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you verify this same result for when 0 < sizeHint < 4096?

Can you also update CanGetNewMemoryWhenSizeTooLarge to verify that memoryLarge.Length is equal to MemoryPool<byte>.MaxBufferSize?

halter73
halter73 reviewed Jan 30, 2019
View reviewed changes
@Tratcher Tratcher removed their request for review January 30, 2019 23:25
@jkotalik jkotalik requested a review from Tratcher as a code owner February 1, 2019 18:09
@Tratcher Tratcher removed their request for review February 1, 2019 18:11
@jkotalik
Copy link
Contributor Author

jkotalik commented Feb 4, 2019

Not sure why the last test run failed:

2019-02-01T18:41:16.1474664Z   Total tests: Unknown. Passed: 22139. Failed: 0. Skipped: 52.
2019-02-01T18:41:16.1476790Z   Test Run Aborted.
2019-02-01T18:41:16.1477604Z   Test execution time: 3.6984 Minutes

@jkotalik jkotalik closed this Feb 4, 2019
@jkotalik jkotalik reopened this Feb 4, 2019
@davidfowl
Copy link
Member

davidfowl commented Feb 4, 2019 •
edited
Loading

An abort usually means there's a crash on a background thread somewhere

@halter73
Copy link
Member

halter73 commented Feb 4, 2019

If it's a debug build, Debug.Assert failures are one of the more common reasons for aborted test runs.

@jkotalik jkotalik closed this Feb 4, 2019
@jkotalik jkotalik reopened this Feb 4, 2019
@jkotalik
Copy link
Contributor Author

jkotalik commented Feb 4, 2019

We didn't get artifacts for test runs. Fix: #7251

@jkotalik jkotalik merged commit 9251dfe into master Feb 4, 2019
@jkotalik jkotalik deleted the jkotalik/correctSegmentSize branch February 4, 2019 23:45
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 approved these changes

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jkotalik @davidfowl @halter73 @Eilon @amcasey