Skip to content

Revert feature that resets unspecified component parameters to default. Fixes #6864 #6931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2019
Merged

Revert feature that resets unspecified component parameters to default. Fixes #6864 #6931

merged 1 commit into from
Jan 23, 2019

Conversation

SteveSandersonMS
Copy link
Member

See the discussion in #6864. This fix is necessary to make the following very basic scenario work:

[Parameter] int IncrementAmount { get; set; } = 1;

@SteveSandersonMS SteveSandersonMS added this to the 3.0.0-preview2 milestone Jan 22, 2019
@SteveSandersonMS
Copy link
Member Author

cc @danroth27

@natemcmaster natemcmaster merged commit a1d49e1 into master Jan 23, 2019
@natemcmaster natemcmaster deleted the stevesa/fix-6864-parameter-defaults branch January 23, 2019 00:16
@SteveSandersonMS SteveSandersonMS mentioned this pull request Feb 19, 2019
Closed
@Andrzej-W Andrzej-W mentioned this pull request May 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rynowak rynowak rynowak approved these changes

+1 more reviewer

@mkArtakMSFT mkArtakMSFT mkArtakMSFT approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0-preview2
Development

Successfully merging this pull request may close these issues.
4 participants
@SteveSandersonMS @rynowak @mkArtakMSFT @natemcmaster