Skip to content

Try re-enabling CancellationToken tests in a loop #6755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 8, 2019
Merged

Try re-enabling CancellationToken tests in a loop #6755

merged 2 commits into from
Feb 8, 2019

Conversation

jkotalik
Copy link
Contributor

To diagnose #4621.

@jkotalik jkotalik requested a review from Tratcher as a code owner January 16, 2019 19:28
@jkotalik jkotalik closed this Jan 16, 2019
@jkotalik jkotalik reopened this Jan 16, 2019
@jkotalik jkotalik closed this Jan 17, 2019
@jkotalik jkotalik reopened this Jan 17, 2019
@jkotalik jkotalik closed this Jan 17, 2019
@jkotalik jkotalik reopened this Jan 17, 2019
@jkotalik
Copy link
Contributor Author

@Tratcher @davidfowl I've tried multiple things to try to reproduce this issue:

  • Go onto the CI machine that had the failure and run all four fail tests ~50000 times.
  • Run with my computer on low power mode.
  • Add Task.Delays in appropriate places

I added some logging (which is bad for perf) to try to catch the issue when it occurs. Other than that, I'm open to anything.

@jkotalik jkotalik requested a review from davidfowl January 18, 2019 17:55
Tratcher
Tratcher reviewed Jan 18, 2019
View reviewed changes
@jkotalik jkotalik force-pushed the jkotalik/cancellationTestIssues branch from 8dffcc8 to 030d457 Compare February 8, 2019 02:33
@jkotalik
Copy link
Contributor Author

jkotalik commented Feb 8, 2019

@Tratcher I'm just going to re-enable the tests here. I couldn't repro by running this on aspnetci.

@jkotalik jkotalik merged commit e3d0dc0 into master Feb 8, 2019
@jkotalik jkotalik deleted the jkotalik/cancellationTestIssues branch February 8, 2019 18:13
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@davidfowl davidfowl Awaiting requested review from davidfowl

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkotalik @Tratcher @Eilon @amcasey