Remove the trailing '/' from logged localhost message #63111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a logging inconsistency where localhost URLs were displayed with a trailing slash while .localhost addresses were not. The change ensures consistent URL formatting in Kestrel's address logging by trimming the trailing slash from localhost addresses.
- Removes trailing slash from localhost address logging to match .localhost address format
- Improves consistency in logged URL formatting
Co-authored-by: Copilot <[email protected]>
halter73
reviewed
Aug 4, 2025
This was referenced Aug 4, 2025
…ice.cs" This reverts commit de24561.
|
@halter73 @BrennanConroy @DeagleGross this is ready for re-review. |
BrennanConroy
approved these changes
Aug 5, 2025
DamianEdwards
deleted the
damianedwards/fix-localhost-log-trailing-slash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that when using a URL like
myapp.dev.localhostwith the new templates, Kestrel logs both themyapp.dev.localhostandlocalhostaddresses, but for thelocalhostaddress it includes the trailing slash (due to us using Uri.ToString()). This fixes it so that the slash isn't logged, aligning it with the format of the .localhost address.