Skip to content

Implement POSIX signal handling for DevServer to fix port release issues #62780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 58 additions & 1 deletion src/Components/WebAssembly/DevServer/src/Program.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Runtime.InteropServices;
using Microsoft.AspNetCore.Hosting;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Hosting;
using DevServerProgram = Microsoft.AspNetCore.Components.WebAssembly.DevServer.Server.Program;

Expand All @@ -11,7 +13,62 @@ internal sealed class Program
{
static int Main(string[] args)
{
DevServerProgram.BuildWebHost(args).Run();
var host = DevServerProgram.BuildWebHost(args);

// Register POSIX signal handlers for graceful shutdown on Unix systems
if (OperatingSystem.IsLinux() || OperatingSystem.IsMacOS())
{
using var lifetime = new DevServerLifetime(host.Services.GetRequiredService<IHostApplicationLifetime>());
host.Run();
}
else
{
host.Run();
}

return 0;
}
}

internal sealed class DevServerLifetime : IDisposable
{
private readonly IHostApplicationLifetime _applicationLifetime;
private readonly PosixSignalRegistration _sigIntRegistration;
private readonly PosixSignalRegistration _sigQuitRegistration;
private readonly PosixSignalRegistration _sigTermRegistration;

private bool _disposed;

public DevServerLifetime(IHostApplicationLifetime applicationLifetime)
{
_applicationLifetime = applicationLifetime;

Action<PosixSignalContext> handler = HandlePosixSignal;
_sigIntRegistration = PosixSignalRegistration.Create(PosixSignal.SIGINT, handler);
_sigQuitRegistration = PosixSignalRegistration.Create(PosixSignal.SIGQUIT, handler);
_sigTermRegistration = PosixSignalRegistration.Create(PosixSignal.SIGTERM, handler);
}

public void Dispose()
{
if (_disposed)
{
return;
}

_disposed = true;

_sigIntRegistration.Dispose();
_sigQuitRegistration.Dispose();
_sigTermRegistration.Dispose();
}

private void HandlePosixSignal(PosixSignalContext context)
{
// Request graceful shutdown
_applicationLifetime.StopApplication();

// Don't terminate the process immediately, wait for the application to exit gracefully.
context.Cancel = true;
}
}
Loading