Skip to content

[Blazor] Use Microsoft.DotNet.HotReload.Agent package #61821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 13, 2025

Conversation

maraf
Copy link
Member

@maraf maraf commented May 7, 2025

Replace custom sources with Microsoft.DotNet.HotReload.Agent package.
Sources are restored inside the repo on CI and thus we need to suppress some formatting in editorconfig.

Contributes to #61272

@maraf maraf self-assigned this May 7, 2025
@maraf maraf added the area-blazor Includes: Blazor, Razor Components label May 7, 2025
@maraf maraf marked this pull request as ready for review May 13, 2025 14:40
@maraf maraf requested review from a team and wtgodbe as code owners May 13, 2025 14:40
Comment on lines +28 to +29
<LatestPackageReference Include="Microsoft.DotNet.HotReload.Agent" />
<LatestPackageReference Include="Microsoft.DotNet.HotReload.Agent.Data" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this essentially a sources package?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, is the plan for this code to end up in the runtime eventually (To enable HotReload outside Blazor).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this essentially a sources package?

Yes

Also, is the plan for this code to end up in the runtime eventually (To enable HotReload outside Blazor).

Yes-ish. The plan is that it ends somewhere, where runtime template can use it as well, including the bootstrap logic. I don't know that exact shape yet

@maraf maraf merged commit 67f31e7 into dotnet:main May 13, 2025
27 checks passed
@maraf maraf deleted the BlazorHotReloadPackage branch May 13, 2025 17:14
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview5 milestone May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants