Skip to content

Conversation

akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Jun 17, 2024

@akoeplinger akoeplinger requested review from wtgodbe and a team as code owners June 17, 2024 14:21
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 17, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 8.0.x milestone Jun 17, 2024
@akoeplinger
Copy link
Member Author

Infrastructure change without which we can't build, adding tell-mode label.

@akoeplinger akoeplinger added the tell-mode Indicates a PR which is being merged during tell-mode label Jun 17, 2024
@wtgodbe
Copy link
Member

wtgodbe commented Jun 17, 2024

Thanks!

@wtgodbe
Copy link
Member

wtgodbe commented Jun 17, 2024

Will merge this when the branches open up again

@akoeplinger
Copy link
Member Author

/backport to release/6.0

Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/9551579425

@akoeplinger
Copy link
Member Author

Failures here also happened after retry:

[xUnit.net 00:33:24.79]     Microsoft.AspNetCore.Components.E2ETest.Tests.WebAssemblyPrerenderedTest.CanPrerenderAndAddHeadOutletRootComponent [FAIL]
  Failed Microsoft.AspNetCore.Components.E2ETest.Tests.WebAssemblyPrerenderedTest.CanPrerenderAndAddHeadOutletRootComponent [16 ms]
  Error Message:
   System.IO.DirectoryNotFoundException : Test is configured to use trimmed outputs, but trimmed outputs were not found in /home/vsts/work/1/s/src/Components/test/E2ETest/bin/Release/net8.0/trimmed-or-threading/Wasm.Prerendered.Server.
  Stack Trace:
     at Microsoft.AspNetCore.Components.E2ETest.Tests.WebAssemblyPrerenderedTest.GetPublishedContentRoot(Assembly assembly) in /home/vsts/work/1/s/src/Components/test/E2ETest/Tests/WebAssemblyPrerenderedTest.cs:line 63
   at Microsoft.AspNetCore.Components.E2ETest.Infrastructure.ServerFixtures.AspNetSiteServerFixture.CreateWebHost() in /home/vsts/work/1/s/src/Components/test/E2ETest/Infrastructure/ServerFixtures/AspNetSiteServerFixture.cs:line 35
   at Microsoft.AspNetCore.Components.E2ETest.Infrastructure.ServerFixtures.WebHostServerFixture.StartAndGetRootUri() in /home/vsts/work/1/s/src/Components/test/E2ETest/Infrastructure/ServerFixtures/WebHostServerFixture.cs:line 16
   at Microsoft.AspNetCore.Components.E2ETest.Infrastructure.ServerFixtures.ServerFixture.<.ctor>b__4_0() in /home/vsts/work/1/s/src/Components/test/E2ETest/Infrastructure/ServerFixtures/ServerFixture.cs:line 22
   at System.Lazy`1.ViaFactory(LazyThreadSafetyMode mode)
--- End of stack trace from previous location ---
   at System.Lazy`1.CreateValue()
   at Microsoft.AspNetCore.Components.E2ETest.Infrastructure.ServerTestBase`1.Navigate(String relativeUrl, Boolean noReload) in /home/vsts/work/1/s/src/Components/test/E2ETest/Infrastructure/ServerTestBase.cs:line 31
   at Microsoft.AspNetCore.Components.E2ETest.Tests.WebAssemblyPrerenderedTest.CanPrerenderAndAddHeadOutletRootComponent() in /home/vsts/work/1/s/src/Components/test/E2ETest/Tests/WebAssemblyPrerenderedTest.cs:line 38
   at InvokeStub_WebAssemblyPrerenderedTest.CanPrerenderAndAddHeadOutletRootComponent(Object, Object, IntPtr*)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

@wtgodbe
Copy link
Member

wtgodbe commented Jun 26, 2024

Failure is unrelated

@wtgodbe wtgodbe merged commit 3ffafee into release/8.0 Jul 2, 2024
@wtgodbe wtgodbe deleted the fix-macos-11 branch July 2, 2024 20:33
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 8.0.x, 8.0.8 Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants