Skip to content

Unquarantine HtmlGenerationWithCultureTest.CacheTagHelper_VaryByCultureComposesWithOtherVaryByOptions #55858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2024
Merged

Unquarantine HtmlGenerationWithCultureTest.CacheTagHelper_VaryByCultureComposesWithOtherVaryByOptions #55858

merged 1 commit into from
Jun 11, 2024

Conversation

RussKie
Copy link
Contributor

@RussKie RussKie commented May 24, 2024 •
edited
Loading

Resolves #4907

It has been passing for a while:
image

@RussKie RussKie requested review from halter73 and wtgodbe May 24, 2024 01:39
@RussKie RussKie requested a review from a team as a code owner May 24, 2024 01:39
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label May 24, 2024
@halter73
Copy link
Member

Based on #55930, I don't think we should merge this yet. There must be some undiscovered root cause to all of these timeouts.

@amcasey

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jun 5, 2024
@javiercn javiercn enabled auto-merge (squash) June 11, 2024 08:09
@javiercn javiercn merged commit 2b5d2b3 into main Jun 11, 2024
@javiercn javiercn deleted the Unquarantine_HtmlGenerationWithCultureTest.CacheTagHelper_VaryByCultureComposesWithOtherVaryByOptions branch June 11, 2024 08:10
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview6 milestone Jun 11, 2024
@captainsafia captainsafia mentioned this pull request Jun 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiercn javiercn javiercn approved these changes

@halter73 halter73 Awaiting requested review from halter73

@wtgodbe wtgodbe Awaiting requested review from wtgodbe

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Milestone
9.0-preview6
Development

Successfully merging this pull request may close these issues.

Test failure: CacheTagHelper_AllowsVaryingByUICulture and CacheTagHelper_VaryByCultureComposesWithOtherVaryByOptions
3 participants
@RussKie @halter73 @javiercn