Skip to content

Comment out selenium/standalone-chrome container images. #55812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2024
Merged

Comment out selenium/standalone-chrome container images. #55812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/Components/benchmarkapps/Wasm.Performance/dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,18 @@ RUN .dotnet/dotnet publish -c Release --no-restore -o /app ./src/Components/benc
RUN chmod +x /app/Wasm.Performance.Driver

WORKDIR /app
FROM selenium/standalone-chrome:124.0 as final
# NOTE: This has been commented out because it is causing our builds to get a build warning
# because we are pulling this container image from docker.io. We should consider whether
# we need this code in our repo at all, and if not remove it.
# If we do need it then we need to get the container image imported into mcr.microsoft.com
#
# I have opened up a PR to do this, however it is not certain we'll be allowed to do this
# and there is further legal/compliance work that needs to be done. In the meantime commenting
# this out should get our builds to green again whilst this issue is resolved.
#
# PR: https://github.com/microsoft/mcr/pull/3232
#
# FROM selenium/standalone-chrome:124.0 as final
COPY --from=build ./app ./
COPY ./exec.sh ./

Expand Down
13 changes: 12 additions & 1 deletion src/Components/benchmarkapps/Wasm.Performance/local.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,15 @@
FROM selenium/standalone-chrome:latest as final
# NOTE: This has been commented out because it is causing our builds to get a build warning
# because we are pulling this container image from docker.io. We should consider whether
# we need this code in our repo at all, and if not remove it.
# If we do need it then we need to get the container image imported into mcr.microsoft.com
#
# I have opened up a PR to do this, however it is not certain we'll be allowed to do this
# and there is further legal/compliance work that needs to be done. In the meantime commenting
# this out should get our builds to green again whilst this issue is resolved.
#
# PR: https://github.com/microsoft/mcr/pull/3232
#
# FROM selenium/standalone-chrome:latest as final

ENV StressRunDuration=0

Expand Down