Skip to content

Fix exit code propagation when building inside the VMR #55201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2024
Merged

Fix exit code propagation when building inside the VMR #55201

merged 2 commits into from
Apr 18, 2024

Conversation

@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Apr 18, 2024

@ViktorHofer ViktorHofer requested review from a team and wtgodbe as code owners April 18, 2024 14:41
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 18, 2024
amcasey
amcasey approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's give @wtgodbe some time.

@mmitche mmitche merged commit 8321d83 into main Apr 18, 2024
@mmitche mmitche deleted the ViktorHofer-patch-1 branch April 18, 2024 20:55
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview4 milestone Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmitche mmitche mmitche approved these changes

@amcasey amcasey amcasey approved these changes

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

9.0-preview4

Development

Successfully merging this pull request may close these issues.

Outer build swallowing errors

4 participants

@ViktorHofer @mmitche @amcasey