Skip to content

Add automatic SDK updates #53414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Add automatic SDK updates #53414

merged 2 commits into from
Jan 16, 2024

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jan 16, 2024

Add a workflow to automatically update the SDK on Monday. Will update the build-ops docs once this is in.

CC @blowdart we're pinning to the v3.1.0 tag per your request

@wtgodbe wtgodbe requested a review from blowdart January 16, 2024 17:58
@wtgodbe wtgodbe requested a review from a team as a code owner January 16, 2024 17:58
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 16, 2024
@wtgodbe
Copy link
Member Author

wtgodbe commented Jan 16, 2024

I'll test out the workflow once it's in main.

@ghost
Copy link

ghost commented Jan 16, 2024

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@wtgodbe wtgodbe mentioned this pull request Jan 16, 2024
@blowdart
Copy link
Contributor

Please pin to the commit ID not the version

See https://blog.rafaelgss.dev/why-you-should-pin-actions-by-commit-hash

Copy link
Contributor

@blowdart blowdart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning to commit ID not version

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: martincostello/[email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated

@wtgodbe wtgodbe merged commit 2c13e06 into main Jan 16, 2024
@wtgodbe wtgodbe deleted the wtgodbe/SDKUp branch January 16, 2024 20:31
@ghost ghost added this to the 9.0-preview1 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants