Skip to content

Update editorconfig with naming rules #50854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Update editorconfig with naming rules #50854

merged 1 commit into from
Sep 27, 2023

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Sep 21, 2023

  • Private and internal fields start with _
  • Const fields are pascal case

Copied from dotnet/runtime editorconfig.

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 21, 2023
@ghost
Copy link

ghost commented Sep 21, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@danmoseley danmoseley merged commit b3d1545 into main Sep 27, 2023
@danmoseley danmoseley deleted the jamesnk/editorconfig branch September 27, 2023 03:13
@ghost ghost added this to the 9.0-preview1 milestone Sep 27, 2023
@danmoseley
Copy link
Member

has anyone looked through all the csharp_ and dotnet_ entries in the runtime .editorconfig? there are lots we don't have. I wonder whether there are any that align with our practices.

what is the impact of a violation -- just warnings in VS?

@ghost
Copy link

ghost commented Sep 27, 2023

Hi @danmoseley. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@JamesNK
Copy link
Member Author

JamesNK commented Sep 27, 2023

has anyone looked through all the csharp_ and dotnet_ entries in the runtime .editorconfig? there are lots we don't have. I wonder whether there are any that align with our practices.

what is the impact of a violation -- just warnings in VS?

Not even a warning. It's a suggestion, but it drives code generation and refactoring.

Most aspnetcore and runtime standards are the same. Notable differences are around var and private static fields (no s_ prefix in aspnetcore)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants