Skip to content

Add TLS and HTTP protocol to kestrel-connection-duration counter #48723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 13, 2023

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Jun 12, 2023

Fixes #47831

New tags:

  • tls-protocol - The TLS protocol of the connection.

    • Value is SslProtocols converted to a string.
    • Only present if the connection is SSL/TLS.
  • http-protocol - The HTTP protocol of the connection.

    • Value is HTTP/1.1, HTTP/2, HTTP/3.
    • Only present if the connection is HTTP.
    • Note that the value here doesn't necessarily match the version in the HTTP request. For example, the client could send HTTP/1.0 request, and the HTTP/1.1 server connection will process it.

@JamesNK JamesNK enabled auto-merge (squash) June 13, 2023 04:55
@JamesNK JamesNK merged commit 24a2837 into main Jun 13, 2023
@JamesNK JamesNK deleted the jamesnk/kestrel-metrics-protocols branch June 13, 2023 07:19
@ghost ghost added this to the 8.0-preview6 milestone Jun 13, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kestrel connection metrics - add protocol and TLS info?
4 participants