Skip to content

Kestrel connection metrics - add protocol and TLS info? #47831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
JamesNK opened this issue Apr 22, 2023 · 3 comments · Fixed by #48723
Closed
1 task done

Kestrel connection metrics - add protocol and TLS info? #47831

JamesNK opened this issue Apr 22, 2023 · 3 comments · Fixed by #48723
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Comments

@JamesNK
Copy link
Member

JamesNK commented Apr 22, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

Kestrel has a connection-duration counter. Today it just records the local endpoint as a dimension.

Describe the solution you'd like

connection-duration could add additional information that is negotiated after the connection starts.

For example, the connection's:

  • HTTP protocol (HTTP/1.1, HTTP/2, HTTP/3)
  • TLS protocol (Tls10, Tls11, Tls12, Tls13)

Is this valuable?

Additional context

No response

@ghost ghost added the area-runtime label Apr 22, 2023
@gfoidl
Copy link
Member

gfoidl commented Apr 22, 2023

For me:
HTTP protocol: yes
TLS protocol: not needed

Also need to consider that the curse of dimensionality doesn't start to account 😉.

@amcasey
Copy link
Member

amcasey commented Apr 26, 2023

How is the data structured? Is there a side table for tracking metadata about each endpoint or does everything go on every event?

@JamesNK JamesNK modified the milestones: .NET 8.0, .NET 8 Planning Jun 10, 2023
@ghost
Copy link

ghost commented Jun 10, 2023

Thanks for contacting us.

We're moving this issue to the .NET 8 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@ghost ghost locked as resolved and limited conversation to collaborators Jul 13, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants