RDF test migration for some response test cases. #48611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchdenny
requested review from
BrennanConroy,
Tratcher,
captainsafia and
halter73
as code owners
ghost
added
the
src/Http/Http.Extensions/gen/StaticRouteHandlerModel/EndpointResponse.cs
Outdated
Show resolved
Hide resolved
...Http/Http.Extensions/test/RequestDelegateGenerator/RequestDelegateCreationTests.Responses.cs
Outdated
Show resolved
Hide resolved
src/Http/Http.Extensions/gen/StaticRouteHandlerModel/StaticRouteHandlerModel.Emitter.cs
Outdated
Show resolved
Hide resolved
src/Http/Http.Extensions/gen/StaticRouteHandlerModel/StaticRouteHandlerModel.Emitter.cs
Outdated
Show resolved
Hide resolved
captainsafia
reviewed
Jun 6, 2023
src/Http/Http.Extensions/gen/StaticRouteHandlerModel/EndpointResponse.cs
Show resolved
Hide resolved
src/Http/Http.Extensions/gen/StaticRouteHandlerModel/StaticRouteHandlerModel.Emitter.cs
Show resolved
Hide resolved
| } | ||
| httpContext.Response.ContentType ??= "text/plain"; | ||
| var result = handler(svc_local); | ||
| if (result is string) |
Member
There was a problem hiding this comment.
Yeah, feels like we can do this in the same place where we write the response (as in the ExecuteReturnAsync handlers referenced above) instead of duplicating the check for hte result.
Member
Author
There was a problem hiding this comment.
I might be misunderstanding. If we don't have any filters we don't use ExecuteObjectResult unless I'm misreading the code.
src/Http/Http.Extensions/gen/StaticRouteHandlerModel/EndpointResponse.cs
Show resolved
Hide resolved
src/Http/Http.Extensions/test/RequestDelegateGenerator/RequestDelegateCreationTestBase.cs
Show resolved
Hide resolved
...Http/Http.Extensions/test/RequestDelegateGenerator/RequestDelegateCreationTests.Responses.cs
Outdated
Show resolved
Hide resolved
...Http/Http.Extensions/test/RequestDelegateGenerator/RequestDelegateCreationTests.Responses.cs
Outdated
Show resolved
Hide resolved
amcasey
added
area-minimal
captainsafia
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #47345