Skip to content

[Blazor] SupplyParameterFromForm complex type support. #48567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 7, 2023
Merged

[Blazor] SupplyParameterFromForm complex type support. #48567

merged 4 commits into from
Jun 7, 2023

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented Jun 1, 2023 •
edited
Loading

#46688 (comment)

Comparison against MVC. Without optimizations on this code path.

Method Mean Error StdDev Op/s Ratio RatioSD Gen 0 Gen 1 Gen 2 Allocated
ModelBinding_ComplexTypes_Mvc 76.23 μs 2.240 μs 6.355 μs 13,117.4 1.00 0.00 - - - 5 KB
ModelBinding_ComplexType_Components 32.96 μs 1.322 μs 3.750 μs 30,344.1 0.43 0.06 - - - 4 KB

@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Jun 1, 2023
javiercn
javiercn commented Jun 1, 2023
View reviewed changes
...ents/Endpoints/src/Binding/Factories/ComplexType/ComplexTypeExpressionConverterFactoryOfT.cs

private CompiledComplexTypeConverter<T>.ConverterDelegate CreateConverterBody(Type type, FormDataMapperOptions options)
{
var properties = PropertyHelper.GetVisibleProperties(type);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same logic MVC uses to resolve bindable properties.

@javiercn javiercn marked this pull request as ready for review June 1, 2023 16:23
@javiercn javiercn requested a review from a team as a code owner June 1, 2023 16:23
@javiercn javiercn requested a review from MackinnonBuck June 1, 2023 20:35
@javiercn javiercn force-pushed the javiercn/supply-from-form-dictionaries branch from 6f08454 to fc31f00 Compare June 7, 2023 10:14
@javiercn javiercn requested a review from a team as a code owner June 7, 2023 10:14
@javiercn javiercn force-pushed the javiercn/supply-from-form-objects branch 2 times, most recently from d206210 to 6704586 Compare June 7, 2023 10:35
Base automatically changed from javiercn/supply-from-form-dictionaries to main June 7, 2023 11:38
@javiercn javiercn force-pushed the javiercn/supply-from-form-objects branch from 4b33e70 to 7e56847 Compare June 7, 2023 12:42
@javiercn javiercn merged commit 8dea0b8 into main Jun 7, 2023
@javiercn javiercn deleted the javiercn/supply-from-form-objects branch June 7, 2023 14:09
@ghost ghost added this to the 8.0-preview6 milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MackinnonBuck MackinnonBuck MackinnonBuck approved these changes

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Milestone
8.0-preview6
Development

Successfully merging this pull request may close these issues.
2 participants
@javiercn @MackinnonBuck