Skip to content

[main] Update dependencies from dotnet/runtime #47879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 25, 2023
Merged

[main] Update dependencies from dotnet/runtime #47879

merged 5 commits into from
Apr 25, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: 32db3699-5666-45da-a1b7-08d8b804cd75
  • Build: 20230424.17
  • Date Produced: April 25, 2023 6:14:25 AM UTC
  • Commit: 516aa8c9eab570ba4812af3d971be29333da79d2
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2023…
41afbc6 
…0424.17

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.DirectoryServices.Protocols , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting
 From Version 8.0.0-preview.4.23221.1 -> To Version 8.0.0-preview.4.23224.17
@dotnet-maestro dotnet-maestro bot requested review from a team and wtgodbe as code owners April 25, 2023 12:01
@ghost ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼 labels Apr 25, 2023
ghost
ghost approved these changes Apr 25, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@ghost
Copy link

ghost commented Apr 25, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@lewing lewing mentioned this pull request Apr 25, 2023
Merged
@lewing
Copy link
Member

lewing commented Apr 25, 2023

This is blocking installer sourcebuild now too

cc @stephentoub

@lewing lewing requested review from a team, Tratcher and BrennanConroy as code owners April 25, 2023 17:14
@lewing lewing enabled auto-merge (squash) April 25, 2023 17:53
eerhardt
eerhardt reviewed Apr 25, 2023
View reviewed changes
@lewing
Copy link
Member

lewing commented Apr 25, 2023 •
edited
Loading

Can someone who understands the code better take a look at the current failures, they at first glance don't look like they are related to the FlushAsync addition

@eerhardt
Copy link
Member

The current failures look like a fallout of dotnet/runtime@620b0db.

aspnetcore/src/Mvc/Mvc.Localization/test/HtmlLocalizerTest.cs

Line 153 in 47d0784

Assert.Equal("Input string was not in a correct format.", exception.Message); 

2023-04-25T18:01:21.3098400Z [xUnit.net 00:00:00.84]       Assert.Equal() Failure
2023-04-25T18:01:21.3099100Z [xUnit.net 00:00:00.84]                                        ↓ (pos 41)
2023-04-25T18:01:21.3099710Z [xUnit.net 00:00:00.84]       Expected: ···in a correct format.
2023-04-25T18:01:21.3099710Z [xUnit.net 00:00:00.84]     Microsoft.AspNetCore.Mvc.Localization.Test.HtmlLocalizerTest.HtmlLocalizer_HtmlWithInvalidResourceString_ContentThrowsException(format: "{") [FAIL]
2023-04-25T18:01:21.3100890Z [xUnit.net 00:00:00.84]       Actual:   ···in a correct format. Failure to parse near offset 1. Format i···
2023-04-25T18:01:21.3101710Z [xUnit.net 00:00:00.84]                                        ↑ (pos 41)
2023-04-25T18:01:21.3102180Z [xUnit.net 00:00:00.84]       Stack Trace:
2023-04-25T18:01:21.3102830Z [xUnit.net 00:00:00.84]         /_/src/Mvc/Mvc.Localization/test/HtmlLocalizerTest.cs(153,0): at Microsoft.AspNetCore.Mvc.Localization.Test.HtmlLocalizerTest.HtmlLocalizer_HtmlWithInvalidResourceString_ContentThrowsException(String format)
2023-04-25T18:01:21.3103940Z [xUnit.net 00:00:00.84]            at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
2023-04-25T18:01:21.3104570Z [xUnit.net 00:00:00.84]            at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
2023-04-25T18:01:21.3105140Z [xUnit.net 00:00:00.84]     Microsoft.AspNetCore.Mvc.Localization.Test.HtmlLocalizerTest.HtmlLocalizer_HtmlWithInvalidResourceString_ContentThrowsException(format: "{0") [FAIL]

I'm fixing them now.

@stephentoub
Copy link
Member

The current failures look like a fallout

No good deed goes unpunished. That'll teach me to include helpful information in error messages.

@lewing
Copy link
Member

lewing commented Apr 25, 2023

new failures

@eerhardt
Copy link
Member

new failures

It looks like a transient issue. I reran the failing job to see if it passes.

@lewing lewing merged commit 7f2691d into main Apr 25, 2023
@lewing lewing deleted the darc-main-e3759e35-f59a-412e-95c9-6600937f24b5 branch April 25, 2023 22:19
@ghost ghost added this to the 8.0-preview4 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub left review comments

@eerhardt eerhardt eerhardt left review comments

@Tratcher Tratcher Tratcher approved these changes

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼
Projects
None yet
Milestone
8.0-preview4
Development

Successfully merging this pull request may close these issues.
4 participants
@lewing @eerhardt @stephentoub @Tratcher