Update MessagePack version #47790
Merged
Update MessagePack version #47790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
requested review from
halter73,
a team and
wtgodbe
as code owners
wtgodbe
approved these changes
Apr 19, 2023
2 tasks
amcasey
approved these changes
Apr 25, 2023
| @@ -79,8 +79,12 @@ private HubMessage CreateInvocationMessage(ref MessagePackReader reader, IInvoca | |||
| } | |||
|
|
|||
| var target = ReadString(ref reader, binder, "target"); | |||
| if (string.IsNullOrEmpty(target)) | |||
There was a problem hiding this comment.
Not really, it would have thrown later at the binder.GetParameterTypes(target) call, which would result in slightly different exception behavior. This just provides a more accurate exception message.
| @@ -79,8 +79,12 @@ private HubMessage CreateInvocationMessage(ref MessagePackReader reader, IInvoca | |||
| } | |||
|
|
|||
| var target = ReadString(ref reader, binder, "target"); | |||
| if (string.IsNullOrEmpty(target)) | |||
| { | |||
| throw new InvalidDataException("Null or empty target for Invocation message."); | |||
There was a problem hiding this comment.
Would it be useful to indicate whether it was null or empty? Also, is empty actually possible or will it always end up null if it's missing?
There was a problem hiding this comment.
Both should be possible (I explicitly added empty string tests for all these new exceptions). And when I say should, it's only possible if someone manually tries to implement the protocol and gets it wrong. Which is why I don't think it's important to distinguish between them.
src/SignalR/common/Protocols.MessagePack/src/Protocol/MessagePackHubProtocolWorker.cs
Outdated
Show resolved
Hide resolved
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #46787
The update included nullable annotations in the msgpack library.