Skip to content

Update TryParse code gen to use CodeWriter. #46928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 3, 2023
Merged

Update TryParse code gen to use CodeWriter. #46928

merged 7 commits into from
Mar 3, 2023

Conversation

mitchdenny
Copy link
Member

This PR updates the TryParse block emitter to use code writer. Effectively changing the ParsingBlockEmitter from Func<string,string,string> to Action<CodeWriter,string,string>.

@ghost ghost added the area-runtime label Feb 28, 2023
captainsafia
captainsafia reviewed Feb 28, 2023
View reviewed changes
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snapshot updates?

@mitchdenny
Copy link
Member Author

Snapshot updates?

Not necessary in this case. The existing snapshots are correct. If we merge this then I'll rebase my other PR on it and it probably won't need snapshot updates either ;)

@build-analysis build-analysis bot mentioned this pull request Feb 28, 2023
Open
5 tasks
@mitchdenny mitchdenny mentioned this pull request Mar 1, 2023
Merged
@mitchdenny mitchdenny enabled auto-merge (squash) March 1, 2023 04:55
@captainsafia
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@mitchdenny mitchdenny force-pushed the rdg-tryparse-code-writer branch from cad3282 to 09046e6 Compare March 3, 2023 00:19
@build-analysis build-analysis bot mentioned this pull request Mar 3, 2023
Closed
5 tasks
@mitchdenny mitchdenny merged commit 5d10dce into dotnet:main Mar 3, 2023
@ghost ghost added this to the 8.0-preview3 milestone Mar 3, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainsafia captainsafia captainsafia approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
8.0-preview3
Development

Successfully merging this pull request may close these issues.
3 participants
@mitchdenny @captainsafia @amcasey