Skip to content

Convert MetaPackages to Reference and move to DefauldBuilder folder #4687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 13, 2018
Merged

Convert MetaPackages to Reference and move to DefauldBuilder folder #4687

merged 2 commits into from
Dec 13, 2018

Conversation

JunTaoLuo
Copy link
Contributor

Part of #4246.

@pakrym pakrym changed the title Convert ServerTests to Reference and move to Server folder Convert MetaPackages to Reference and move to Server folder Dec 13, 2018
natemcmaster
natemcmaster approved these changes Dec 13, 2018
View reviewed changes
@natemcmaster natemcmaster changed the title Convert MetaPackages to Reference and move to Server folder Convert MetaPackages to Reference and move to DefauldBuilder folder Dec 13, 2018
@JunTaoLuo
Copy link
Contributor Author

Turns out I haven't been seeing NU1105 warnings because I turned off automatic Nuget restore in VS. I've updated the solution to remedy this issue though I only had to bring in two extra projects which is less than I anticipated.

@JunTaoLuo JunTaoLuo merged commit a026e7a into release/2.1 Dec 13, 2018
@JunTaoLuo JunTaoLuo deleted the johluo/convert-metapackages branch December 13, 2018 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@natemcmaster natemcmaster natemcmaster approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JunTaoLuo @natemcmaster