[release/6.0] Suppress downgrade error in hosting bundle #46844
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ghost
added
the
area-infrastructure
|
Hi @github-actions[bot]. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
|
Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
|
Approved over email |
wtgodbe
added
Servicing-approved
|
Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
|
The interop test failure is known |
|
@BrennanConroy can you take a look at the signalR npm failure on windows arm64?
Error: error:0308010C:digital envelope routines::unsupported |
|
This is due to an issue with older webpack versions and newer node versions. Can be resolved by updating webpack to >= 5.61.0 or passing --openssl-legacy-provider to node when building. |
If this is the issue showing up in the Windows ARM64 build, have a look at the first commit in https://dev.azure.com/dnceng/internal/_git/dotnet-aspnetcore/pullrequest/29739?_a=commits and duplicate that here. |
eng/targets/Npm.Common.targets
Outdated
| @@ -76,7 +76,7 @@ | |||
| DependsOnTargets="GetBuildInputCacheFile" | |||
| Inputs="@(TSFiles);$(BaseIntermediateOutputPath)tsfiles.cache" | |||
| Outputs="@(BuildOutputFiles)"> | |||
| <Yarn Command="$(NpmBuildArgs)" StandardOutputImportance="High" StandardErrorImportance="High" IgnoreStandardErrorWarningFormat="$(IgnoreYarnWarnings)" /> | |||
| <Yarn Command="$(NpmBuildArgs) --openssl-legacy-provider" StandardOutputImportance="High" StandardErrorImportance="High" IgnoreStandardErrorWarningFormat="$(IgnoreYarnWarnings)" /> | |||
There was a problem hiding this comment.
Use my approach instead unless this is necessary for some job other than the Windows ARM64 one. Just wasteful to build Node JS projects there. Only got into this state because the images were updated.
This reverts commit c8bd24e.
- at one point, `1es-windows-2019` images lacked Node JS - between `Image Version: 49.0.0` and `Image Version: 50.0.0`, Node JS was upgraded to 18.14.0 - this version is not compatible w/ some of our WebPack build processes - stop the Node JS builds in this job; not necessary for the shared Fx
Backport of #46842 to release/6.0
/cc @wtgodbe
Suppress downgrade error in hosting bundle
Allows the hosting bundle installer to run on a machine w/ a newer hosting bundle installed, without exiting with an error.
Description
Allows the hosting bundle installer to run on a machine w/ a newer hosting bundle installed, without exiting with an error.
Fixes #42857
Customer Impact
Fulfills an internal request by the office team
Regression?
[If yes, specify the version the behavior has regressed from]
Risk
This could break a customer who relies on the installer exiting with an error in this scenario, but I think that's unlikely.
Verification
Packaging changes reviewed?
When servicing release/2.1