Skip to content

Suppress downgrade error in hosting bundle #46842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Suppress downgrade error in hosting bundle #46842

merged 1 commit into from
Feb 24, 2023

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Feb 23, 2023

Completes the fix from #42857

Allows a windows hosting bundle to be installed on a machine that already has a newer asp.net hosting bundle installed.

@wtgodbe wtgodbe requested review from joeloff and a team February 23, 2023 18:19
@wtgodbe
Copy link
Member Author

wtgodbe commented Feb 23, 2023

/backport to release/7.0

@wtgodbe
Copy link
Member Author

wtgodbe commented Feb 23, 2023

/backport to release/6.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/aspnetcore/actions/runs/4255630378

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/4255631466

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 23, 2023
@joeloff
Copy link
Member

joeloff commented Feb 23, 2023

@wtgodbe can you create a build to see whether the chained ASP.NET bundle is impacted when downgrading the hosting bundle? I believe the outer bundle should be a no-op so nothing in the chain is executed, but if it is, the ASP.NET bundle would fail with a downgrade error. Things always get weird when we start nesting bundles.

@wtgodbe
Copy link
Member Author

wtgodbe commented Feb 23, 2023

@wtgodbe wtgodbe merged commit 2575e22 into main Feb 24, 2023
@wtgodbe wtgodbe deleted the wtgodbe/hbdowng branch February 24, 2023 17:20
@ghost ghost added this to the 8.0-preview2 milestone Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants