Defer search for dev cert until build bind time #46296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
reviewed
Jan 27, 2023
halter73
reviewed
Jan 27, 2023
src/Servers/Kestrel/Kestrel/test/KestrelConfigurationLoaderTests.cs
Outdated
Show resolved
Hide resolved
amcasey
requested review from
Tratcher,
BrennanConroy,
JamesNK and
mgravell
as code owners
|
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
ghost
added
the
pending-ci-rerun
halter73
reviewed
Feb 15, 2023
Tratcher
reviewed
Feb 15, 2023
...so that it can occur after `IConfiguration` is read. (In particular, so that it occurs during `AddressBinder.BindAsync` which happens strictly after `KestrelConfigurationLoader.Load`.) This is important in Docker scenarios since the Docker tools use `IConfiguration` to tell us where the dev cert directory is mounted. Fixes dotnet#45801
|
Force-push is a trivial rebase. Feedback to be addressed shortly. |
amcasey
removed
the
pending-ci-rerun
|
/azp run |
|
Commenter does not have sufficient privileges for PR 46296 in repo dotnet/aspnetcore |
halter73
approved these changes
Feb 22, 2023
4 tasks
amcasey
added a commit
to amcasey/aspnetcore
that referenced
this pull request
Feb 24, 2023
This reverts commit 303115a. Changing the order in which various certificate loading operations are performed broke dotnet-monitor. dotnet/dotnet-docker#4448 (comment)
amcasey
added a commit
that referenced
this pull request
Feb 24, 2023
…6868) This reverts commit 303115a. Changing the order in which various certificate loading operations are performed broke dotnet-monitor. dotnet/dotnet-docker#4448 (comment)
amcasey
added a commit
to amcasey/aspnetcore
that referenced
this pull request
May 3, 2023
...so that it can occur after IConfiguration is read. (In particular, so that it occurs during AddressBinder.BindAsync which happens strictly after KestrelConfigurationLoader.Load.) This is important in Docker scenarios since the Docker tools use IConfiguration to tell us where the dev cert directory is mounted.# with '#' will be ignored, and an empty message aborts the commit. Was dotnet#46296 Fixes dotnet#45801
4 tasks
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...so that it can occur after
IConfigurationis read. (In particular, so that it occurs duringAddressBinder.BindAsyncwhich happens strictly afterKestrelConfigurationLoader.Load.) This is important in Docker scenarios since the Docker tools useIConfigurationto tell us where the dev cert directory is mounted.Fixes #45801