Skip to content

[AOT] Remove AOT warning suppressions #46015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2023
Merged

[AOT] Remove AOT warning suppressions #46015

merged 1 commit into from
Jan 17, 2023

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented Jan 11, 2023

...introduced in #45604 now that dotnet/runtime#79425 is available.

@ghost ghost added the area-runtime label Jan 11, 2023
@JamesNK
Copy link
Member

JamesNK commented Jan 11, 2023

Some more:

@amcasey
Copy link
Member Author

amcasey commented Jan 11, 2023

Oops, forgot I had a solution filter open.

@amcasey amcasey changed the title Remove AOT warning suppressions [AOT] Remove AOT warning suppressions Jan 11, 2023
@amcasey
Copy link
Member Author

amcasey commented Jan 12, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Jan 12, 2023
Open
5 tasks
@amcasey
Remove AOT warning suppressions
d8c97de 
...introduced in dotnet#45604 now that dotnet/runtime#79425 is available.
@amcasey
Copy link
Member Author

amcasey commented Jan 17, 2023

Force push is just a rebase onto main to pick up the dotnet/runtime changes.

@amcasey amcasey marked this pull request as ready for review January 17, 2023 18:16
eerhardt
eerhardt approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@JamesNK JamesNK merged commit 6cade1b into dotnet:main Jan 17, 2023
@ghost ghost added this to the 8.0-preview1 milestone Jan 17, 2023
@eerhardt eerhardt mentioned this pull request Jan 26, 2023
Closed
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesNK JamesNK JamesNK approved these changes

@eerhardt eerhardt eerhardt approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
8.0-preview1
Development

Successfully merging this pull request may close these issues.
3 participants
@amcasey @JamesNK @eerhardt