Skip to content

[AOT] React to DependencyInjection requires dynamic code changes #45861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JamesNK opened this issue Jan 4, 2023 · 1 comment
Closed

[AOT] React to DependencyInjection requires dynamic code changes #45861

JamesNK opened this issue Jan 4, 2023 · 1 comment
Assignees
@eerhardt
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions blocked The work on this issue is blocked due to some dependency linker-friendliness Tracking linker friendliness NativeAOT
Milestone
8.0-preview1

Comments

@JamesNK
Copy link
Member

JamesNK commented Jan 4, 2023

DependencyInjection is annotated to require dynamic code. Those annotations are changing with dotnet/runtime#79425.

Remove DI related suppressions from our code once DependencyInjection change is available.
@JamesNK JamesNK added NativeAOT linker-friendliness Tracking linker friendliness old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels area-runtime and removed old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels labels Jan 4, 2023
@adityamandaleeka adityamandaleeka added the blocked The work on this issue is blocked due to some dependency label Jan 4, 2023
@adityamandaleeka adityamandaleeka added this to the 8.0-preview1 milestone Jan 4, 2023
@eerhardt eerhardt self-assigned this Jan 10, 2023
@eerhardt
Copy link
Member

Resolved by #46015.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 25, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eerhardt eerhardt

Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions blocked The work on this issue is blocked due to some dependency linker-friendliness Tracking linker friendliness NativeAOT
Projects
None yet
Milestone
8.0-preview1
Development

No branches or pull requests
4 participants
@adityamandaleeka @JamesNK @eerhardt @amcasey