Skip to content

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Jan 10, 2023

Remaining projects from #45954. These projects multi-targeted netstandard2.0 and net462.

Much smaller and more straightforward than last time.

@JamesNK JamesNK marked this pull request as ready for review January 10, 2023 08:03
Copy link
Contributor

@mgravell mgravell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JamesNK
Copy link
Member Author

JamesNK commented Jan 10, 2023

@BrennanConroy FYI a couple of SignalR tests needed to be updated to check for full type name: 44a2566 (#45984). That's the standard when throwing ObjectDisposedException.

@JamesNK JamesNK merged commit 4963b76 into main Jan 11, 2023
@JamesNK JamesNK deleted the jamesnk/throw-helpers-multitargeted branch January 11, 2023 01:26
@ghost ghost added this to the 8.0-preview1 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants