Skip to content

Remove cruft from Win bundle installers #45909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2023
Merged

Remove cruft from Win bundle installers #45909

merged 1 commit into from
Jan 6, 2023

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Jan 6, 2023

  • part of Clean up Windows bundle installers #44582
    • see the "Confusing unused strings and pages in WiX sources" section
  • remove Strings.wxl files in Windows Hosting bundle
  • remove Options page and related strings (options are disabled)
    • also remove a few other unreferenced strings

@dougbu
Remove cruft from Win bundle installers
d1dca48 
- part of #44582
  - see the "Confusing unused strings and pages in WiX sources" section
- remove Strings.wxl files in Windows Hosting bundle
- remove Options page and related strings (options are disabled)
  - also remove a few other unreferenced strings
@dougbu dougbu added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework feature-installers Includes: Installers labels Jan 6, 2023
@dougbu dougbu requested review from joeloff and a team January 6, 2023 01:20
@ghost
Copy link

ghost commented Jan 6, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

wtgodbe
wtgodbe approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of these are setting off any alarm bells for me, if we're sure they're unused then LGTM

@dougbu dougbu merged commit 041a673 into dotnet:main Jan 6, 2023
@dougbu dougbu deleted the dougbu/installer.cleanup.44582/1 branch January 6, 2023 18:37
@ghost ghost added this to the 8.0-preview1 milestone Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@joeloff joeloff Awaiting requested review from joeloff

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework feature-installers Includes: Installers
Projects
None yet
Milestone
8.0-preview1
Development

Successfully merging this pull request may close these issues.
2 participants
@dougbu @wtgodbe