Removed unnecessary projects in Razor #4586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaybhargavb
force-pushed
the
ajbaaska/convert-reference
branch
from
08fd825 to
dcd6332
Compare
rynowak
reviewed
Dec 12, 2018
| <Compile Include="..\Microsoft.VisualStudio.LanguageServices.Razor\Serialization\RazorDiagnosticJsonConverter.cs"> | ||
| <Link>Shared\RazorDiagnosticJsonConverter.cs</Link> | ||
| </Compile> | ||
| </ItemGroup> |
There was a problem hiding this comment.
I assume you moved these into the project? These are still needed fo sho
rynowak
approved these changes
Dec 12, 2018
natemcmaster
approved these changes
Dec 12, 2018
There was a problem hiding this comment.
LGTM. Test failures are known and tracked here:
https://github.com/aspnet/AspNetCore-Internal/issues/1432
https://github.com/aspnet/AspNetCore-Internal/issues/1457
https://github.com/aspnet/AspNetCore-Internal/issues/1500
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer want to keep tooling related assemblies for release/2.1.