-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Added copy parameters to enable parallel build #45779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added copy parameters to enable parallel build #45779
Conversation
Co-authored-by: Javier Calvarro Nelson <[email protected]>
Co-authored-by: Javier Calvarro Nelson <[email protected]>
Thanks for your PR, @dashkodo. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM based on reading of linked issue/PR that was closed and @javiercn's feedback there.
@captainsafia, @mitchdenny Could we do anything to speed up review by dotnet/aspnet-blazor-eng? |
@vuvarov-cantaloupe actually I'm not sure why we are waiting for the Blazor team's input here since this is a change to the MVC code test projects. |
Yep, we can go ahead and merge this. I lapsed and forgot to click the green button when I last reviewed. Sidenote: the process for backporting this to 6.0 and 7.0 is a little more involved. Amongst other things, we'll want to make sure that it's worth backporting (number of upvotes on the issue, impact and existence of workarounds, etc). |
Thank you for the quick response! |
Hi @vuvarov-cantaloupe. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
PR Title
Added parameters to Copy task that is executed for setting up correct dependency environment in the tests.
PR Description
When enabling multiple msbuild nodes it could fail due to locking "xxx.deps.json" files
We have faced with this issue using latest version of microsoft.aspnetcore.mvc.testing nuget package
C:\ZZZZ\nuget\microsoft.aspnetcore.mvc.testing\7.0.1\build\net7.0\Microsoft.AspNetCore.Mvc.Testing.targets(68, 5): error MSB3027: Unable to copy file "D:\XXXX\bin\Release\YYYY.deps.json" to "bin\Release\YYYY.deps.json". The process cannot access the file 'bin\Release\YYYY.deps.json' because it is being used by another process.
Addresses #33757