Skip to content

Conversation

dashkodo
Copy link
Contributor

PR Title
Added parameters to Copy task that is executed for setting up correct dependency environment in the tests.

PR Description
When enabling multiple msbuild nodes it could fail due to locking "xxx.deps.json" files
We have faced with this issue using latest version of microsoft.aspnetcore.mvc.testing nuget package
C:\ZZZZ\nuget\microsoft.aspnetcore.mvc.testing\7.0.1\build\net7.0\Microsoft.AspNetCore.Mvc.Testing.targets(68, 5): error MSB3027: Unable to copy file "D:\XXXX\bin\Release\YYYY.deps.json" to "bin\Release\YYYY.deps.json". The process cannot access the file 'bin\Release\YYYY.deps.json' because it is being used by another process.

Addresses #33757

@dashkodo dashkodo requested a review from a team as a code owner December 27, 2022 18:27
@ghost ghost added old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels community-contribution Indicates that the PR has been added by a community member labels Dec 27, 2022
@ghost
Copy link

ghost commented Dec 27, 2022

Thanks for your PR, @dashkodo. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copy link
Member

@mitchdenny mitchdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on reading of linked issue/PR that was closed and @javiercn's feedback there.

@vuvarov-cantaloupe
Copy link

@captainsafia, @mitchdenny Could we do anything to speed up review by dotnet/aspnet-blazor-eng?
This issue stops us from .NET 6.0 -> 7.0 migration.

@mitchdenny
Copy link
Member

@vuvarov-cantaloupe actually I'm not sure why we are waiting for the Blazor team's input here since this is a change to the MVC code test projects.

@captainsafia
Copy link
Member

@vuvarov-cantaloupe actually I'm not sure why we are waiting for the Blazor team's input here since this is a change to the MVC code test projects.

Yep, we can go ahead and merge this. I lapsed and forgot to click the green button when I last reviewed.

Sidenote: the process for backporting this to 6.0 and 7.0 is a little more involved. Amongst other things, we'll want to make sure that it's worth backporting (number of upvotes on the issue, impact and existence of workarounds, etc).

@captainsafia captainsafia merged commit cbb4916 into dotnet:main Jan 20, 2023
@ghost ghost added this to the 8.0-preview1 milestone Jan 20, 2023
@vuvarov-cantaloupe
Copy link

Thank you for the quick response!

@ghost
Copy link

ghost commented Jan 20, 2023

Hi @vuvarov-cantaloupe. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community-contribution Indicates that the PR has been added by a community member old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants