Resolve parameter name with FromRouteAttribute in tooling #45720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
added
the
old-area-web-frameworks-do-not-use
JamesNK
requested review from
brunolins16,
captainsafia,
halter73 and
mitchdenny
ghost
added
the
area-infrastructure
5 tasks
mitchdenny
reviewed
Dec 22, 2022
| public class TestController | ||
| { | ||
| [HttpGet(@""{id}"")] |
Member
There was a problem hiding this comment.
Should decide if we need an analyzer to pick up when route parameters are missing from the route pattern.
mitchdenny
reviewed
Dec 22, 2022
Member
mitchdenny
left a comment
mitchdenny
left a comment
There was a problem hiding this comment.
LGTM. Once this is merged I'll rework my PR to use the shared bits.
Member
Author
|
Did you mean to approve? |
Tratcher
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal APIs and controller actions allow an argument to customize its matching route parameter name with
[FromRoute(Name = "Test")].This PR updates various route tooling bits to use the route name from the argument attribute.