Revert "Bump SDK to 8.0.100-alpha.1.22616.4" #45639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9457554.
brunolins16
requested review from
Tratcher,
halter73,
BrennanConroy,
JamesNK,
mgravell,
a team,
dougbu and
wtgodbe
as code owners
sebastienros
approved these changes
Dec 17, 2022
wtgodbe
approved these changes
Dec 17, 2022
There will always be some scenarios (e.g. publishing) that won't be validated by PR CI, but I agree that binlogs don't need to be one of them. I've been leaning towards turning binlogs on in PRs for a while, this seems like more good evidence that we should do that. Can you file an issue to re-enable binlogs in PRs & assign it to me? |
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #44925
Unfortunately, after different engineers working on it and validating the update. After we merged the change our internal CI build is failing with:
The FR teams is working on the update of
MSBuild.StructuredLoggerdotnet/source-indexer#109, however, look into the source code https://github.com/KirillOsenkov/MSBuildStructuredLog/blob/main/src/StructuredLogger/BinaryLogger/BinaryLogger.cs#L58 I don't believe the version 15 is supported yet and it will take longer to make it work again.Since we usually update every Monday, will let the next Monday update check if the newer version dotnet/arcade#11995 will work.
Also, I believe we need make sure the tools used in the CI build are validated in PR validation as well